codemirror renderer in pythoncode doesn't properly escape initial code #102
Labels
No labels
accessibility
backport to lts
bug
code
critical
cygwin
documentation
duplicate
error reporting
external
feature
feedback
good first issue
help wanted
infrastructure
invalid
investigate
language spec
logs
lti
lts only
mac
maybe
qtype:bigbox
qtype:checkoff
qtype:expression
qtype:fileupload
qtype:multiexpression
qtype:multiplechoice
qtype:number
qtype:pythoncode
qtype:pythonic
qtype:pythonliteral
qtype:richtext
qtype:smallbox
question
question types
sandbox
security
syntax highlighting
ui/ux
wontfix
wsl
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
catsoop/catsoop#102
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This caused problems in a 6.101 quiz just a few moments ago. 6.101 was doing something unexpected (
csq_initialchanged from student to student, with student-crafted code), but it still should have worked. The fix should be as simple as callinghtml.escapeon the initial display inrender_html_codemirrorthe same way we call it on submitted code, but we'll need some testing to verify that.codemirrrorrenderer inpythoncodedoesn't properly escapecsq_initialcodemirrrorrenderer inpythoncodedoesn't properly escape initial codecodemirrrorrenderer inpythoncodedoesn't properly escape initial codecodemirrorrenderer inpythoncodedoesn't properly escape initial codeAfter giving some time for my understanding of the problem to evolve, I'm making an executive decision that we should remove Codemirror from the codebase completely in v20.0.0. I'm also noting that this may no longer be a "good first issue" as it's likely at least a little bit complicated.