Broken Rendering (maybe dependent on mistletoe version?) #73
Labels
No labels
accessibility
backport to lts
bug
code
critical
cygwin
documentation
duplicate
error reporting
external
feature
feedback
good first issue
help wanted
infrastructure
invalid
investigate
language spec
logs
lti
lts only
mac
maybe
qtype:bigbox
qtype:checkoff
qtype:expression
qtype:fileupload
qtype:multiexpression
qtype:multiplechoice
qtype:number
qtype:pythoncode
qtype:pythonic
qtype:pythonliteral
qtype:richtext
qtype:smallbox
question
question types
sandbox
security
syntax highlighting
ui/ux
wontfix
wsl
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
catsoop/catsoop#73
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I'm getting some broken rendering on some of my machines with the same catsoop version and Python version. It looks like a Markdown issue, so maybe something changed in mistletoe that we need to account for?
If that is the issue, maybe we should also specify versions of the packages we need in
requirements.txt(but then we need to be careful to keep that file up to date as things are updated).@shensquared, have you noticed any of these kinds of issues in 6.390?
Broken Rendering (maybe dpendent on mistletoe version?)to Broken Rendering (maybe dependent on mistletoe version?)Then again, updating
mistletoeto 1.1.0 (from 0.9.0) on my other machine did not cause anything to break. And py.mit.edu is running on 1.1.0 as well. So now I'm thinking it's not actually a mistletoe issue... 🤔Indeed, mistletoe has caused me (or some TA) compatibility issues on MacOS, with Python 3.9 or 3.10. It was right in a semester beginning and things were too hectic, so I fixed it via a simple rollback
I did briefly look into it, and recall it was almost surely an isolated mistletoe backwards compatibility issue. It's likely the BaseRenderer.getattr() mentioned in Version 0.9 notes https://github.com/miyuchina/mistletoe/releases (but I didn't get to the bottom of it so not sure)
Also, fwiw, I do find a version-fixed
requirement.txtsuper helpful. But I put it inside the course repo likespring23, not the catsoop source repo. It's easier (less risky) to maintain;--force-reinstallcan take care of potential override over upstream catsoop; and I also get the additional benefit of full control over e.g.numpyversion controls as well. https://airr.mit.edu/fall23/staff/local_copy actually reflects the most up-to-date of my own personal workflow (and tested just last night on Mac)just found my chat with the TA. the culprit was actually a different/known mistletoe breaking change that seems fixed at the time. dependency rollback was just the easier band-aid.
here's the full context fwiw.
Ah, OK, thanks. That was actually a separate issue (fixed in
fe51a77067about a year ago 😸) so I think there is something else going on here (though I still haven't been able to figure out quite what's going on).My issue is actually looking like it's an issue with 6.101 specifically, so I'm going to close this for now. Sorry for the spam, Shen!